[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

2020-02-14 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:98 + case SK::TemplateTypeParm: + case SK::TemplateTemplateParm: return CompletionItemKind::Class; hokein wrote: > I think thes

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

2020-02-14 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG84240e0db8ab: [clang][Index] Introduce a TemplateParm SymbolKind (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73696/new/ https://re

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

2020-02-14 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 244619. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73696/new/ https://reviews.llvm.org/D73696 Files: clang-tools-ex

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

2020-02-14 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:98 + case SK::TemplateTypeParm: + case SK::TemplateTemplateParm: return CompletionItemKind::Class; --

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

2020-02-13 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73696/new/ https://reviews.llvm.org/D73696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

2020-02-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Protocol.cpp:265 case index::SymbolKind::Parameter: + case index::SymbolKind::TemplateParm: return SymbolKind::Variable; sammccall wrote: > th

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

2020-02-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 243091. kadircet marked 2 inline comments as done. kadircet added a comment. - As discussed offline, do not expose new symbol kinds to libclang - Set types for templateparms in HoverInfo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

2020-02-05 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Libclang changes need tests I think. Comment at: clang-tools-extra/clangd/Protocol.cpp:265 case index::SymbolKind::Parameter: + case index::SymbolKind::TemplateParm: return SymbolKind::Variable; this seems kind of dubious, ma

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

2020-01-30 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62337 tests passed, 1 failed and 838 were skipped. failed: libc++.std/containers/sequences/array/array_creation/to_array.fail.cpp {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red}

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

2020-01-30 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, ilya-biryukov, kristof.beyls. Herald added a project: clang. Currently template parameters has symbolkind `Unknown`. This patch introduces a new kind `Templat