[PATCH] D73613: [clangd][Hover] Make tests hermetic by setting target triplet

This revision was automatically updated to reflect the committed changes. Closed by commit rG55b0e9c9d5de: [clangd][Hover] Make tests hermetic by setting target triplet (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73613/new/

[PATCH] D73613: [clangd][Hover] Make tests hermetic by setting target triplet

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62269 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73613: [clangd][Hover] Make tests hermetic by setting target triplet

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:586 +// fixed one to make sure tests passes on different platform. +TU.ExtraArgs.push_back("--target=x86_64-pc-linux-gnu"); auto AST = TU.build(); kadircet

[PATCH] D73613: [clangd][Hover] Make tests hermetic by setting target triplet

kadircet updated this revision to Diff 241085. kadircet marked 4 inline comments as done. kadircet added a comment. - Add fixme for delayed-template-parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73613/new/ https://reviews.llvm.org/D73613 F

[PATCH] D73613: [clangd][Hover] Make tests hermetic by setting target triplet

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:583 TU.ExtraArgs.push_back("-std=c++17"); TU.ExtraArgs.push_back("-fno-delayed-template-parsing"); +// Types might be different depending on the target triplet, we chose a

[PATCH] D73613: [clangd][Hover] Make tests hermetic by setting target triplet

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62269 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73613: [clangd][Hover] Make tests hermetic by setting target triplet

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:583 TU.ExtraArgs.push_back("-std=c++17"); TU.ExtraArgs.push_back("-fno-delayed-template-pars

[PATCH] D73613: [clangd][Hover] Make tests hermetic by setting target triplet

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://bugs.llvm.org/show_bug.cgi?id=44696 Repository: rG LLVM Github Monorepo https://revi