[PATCH] D73610: [clangd] Replace raw lexer code with token buffer in prepare rename.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62257 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73610: [clangd] Replace raw lexer code with token buffer in prepare rename.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe864f937669c: [clangd] Replace raw lexer code with token buffer in prepare rename. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73610/

[PATCH] D73610: [clangd] Replace raw lexer code with token buffer in prepare rename.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62257 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73610: [clangd] Replace raw lexer code with token buffer in prepare rename.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:322 +if (!TouchingIdentifier) + return CB(llvm::None); // no rename on non-identifiers. + ---

[PATCH] D73610: [clangd] Replace raw lexer code with token buffer in prepare rename.

hokein updated this revision to Diff 241096. hokein added a comment. revert an accident change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73610/new/ https://reviews.llvm.org/D73610 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-too

[PATCH] D73610: [clangd] Replace raw lexer code with token buffer in prepare rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:322 +if (!TouchingIdentifier) + return CB(llvm::None); // no rename on non-identifiers. + sammccall wrote: > Agree that this behavior is OK per the spec, but do we actual

[PATCH] D73610: [clangd] Replace raw lexer code with token buffer in prepare rename.

hokein updated this revision to Diff 241095. hokein marked 4 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73610/new/ https://reviews.llvm.org/D73610 Files: clang-tools-extra/clan

[PATCH] D73610: [clangd] Replace raw lexer code with token buffer in prepare rename.

sammccall added a comment. Nice, thanks! Comment at: clang-tools-extra/clangd/ClangdServer.cpp:322 +if (!TouchingIdentifier) + return CB(llvm::None); // no rename on non-identifiers. + Agree that this behavior is OK per the spec, but do we actually pre

[PATCH] D73610: [clangd] Replace raw lexer code with token buffer in prepare rename.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62257 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73610: [clangd] Replace raw lexer code with token buffer in prepare rename.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. there is a slight behavior change in this patch: - before: `in^t a;`, returns our internal error message (no