This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG208470dd5d0a: [FPEnv][X86] Platform-specific builtin
constrained FP enablement (authored by kpn).
Repository:
rG LLVM G
craig.topper added a comment.
LGTM to me with that FIXME added.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73570/new/
https://reviews.llvm.org/D73570
___
cfe-commits mailing list
cfe-commits@lists.l
kpn updated this revision to Diff 241771.
kpn added a comment.
Address review comments: FMA tests are now run optimized. This changes where
the FIXME lines are located.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73570/new/
https://reviews.llvm.
kpn marked 2 inline comments as done.
kpn added inline comments.
Comment at: clang/test/CodeGen/fma-builtins-constrained.c:4
+// RUN: %clang_cc1 -ffreestanding %s -triple=x86_64-apple-darwin
-target-feature +fma -S -o - | FileCheck --check-prefix=COMMON
--check-prefix=CHECK-ASM
craig.topper added inline comments.
Comment at: clang/test/CodeGen/fma-builtins-constrained.c:4
+// RUN: %clang_cc1 -ffreestanding %s -triple=x86_64-apple-darwin
-target-feature +fma -S -o - | FileCheck --check-prefix=COMMON
--check-prefix=CHECK-ASM %s
+// RUN: %clang_cc1 -ffre
kpn created this revision.
kpn added reviewers: craig.topper, andrew.w.kaylor.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
[FPEnv][X86] Platform-specific builtin constrained FP enablement
When constrained floating point is enabled the X86-specific builtins don't use
co
