[PATCH] D73547: [Analyzer] Split container modeling from iterator modeling

2020-02-05 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. I'm late to the party, but have looked at the code and I really, really-really like what you did in this patch! It solves one of my biggest complaints about this project. LGTM! Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:1389

[PATCH] D73547: [Analyzer] Split container modeling from iterator modeling

2020-01-28 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ouch, whoops, i didn't notice the new test file. LGTM then! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73547/new/ https://reviews.llvm.org/D73547 _

[PATCH] D73547: [Analyzer] Split container modeling from iterator modeling

2020-01-28 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware added a comment. In D73547#1845339 , @NoQ wrote: > This patch is simply moving code around, right? If so, why did tests need to > be removed? All of the container begin- and end-tests were removed from `iterator-modeling.cpp` and mov

[PATCH] D73547: [Analyzer] Split container modeling from iterator modeling

2020-01-28 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. This patch is simply moving code around, right? If so, why did tests need to be removed? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73547/new/ https://reviews.llvm.org/D73547 ___ cfe-commits