[PATCH] D73521: [analyzer] add-new-checker.py: Introduction

2020-03-31 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso added a comment. In D73521#1951776 , @ASDenysPetrov wrote: > Will this utility affect Visual Studio builds? The community owns like 50 build-bots, so it should affect all of them by default. I am hoping it will just work. CHANGES SINCE LAST

[PATCH] D73521: [analyzer] add-new-checker.py: Introduction

2020-03-31 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. Will this utility affect Visual Studio builds? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73521/new/ https://reviews.llvm.org/D73521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D73521: [analyzer] add-new-checker.py: Introduction

2020-03-30 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso updated this revision to Diff 253777. Charusso marked 3 inline comments as done. Charusso added a comment. Herald added a subscriber: ASDenysPetrov. - Remove the test of creating a live checker, instead copy over the live checker when the script runs. - Simplify the script by adding the

[PATCH] D73521: [analyzer] add-new-checker.py: Introduction

2020-03-30 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso added a comment. In D73521#1923693 , @NoQ wrote: > Or is each test run updating the repo? Can we simply make the script do `cat > DummyChecker.cpp | sed s/DummyChecker/$NAME/g > $NAME.cpp` and store the > checker only once? It was updating, ye

[PATCH] D73521: [analyzer] add-new-checker.py: Introduction

2020-03-15 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D73521#1920130 , @Charusso wrote: > - The script actually creates a real world (hidden) checker. > - This checker always made with the build invocation. > - Its test file always made with the build invocation. Mm, ok, but this

[PATCH] D73521: [analyzer] add-new-checker.py: Introduction

2020-03-15 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/utils/analyzer/add-new-checker.py:83 +except OSError as e: +print('[error] llvm-tblgen is not found, specify it explicitly.') +exit() Let's tell the user politely how to specify `llvm-tblgen`. CHA

[PATCH] D73521: [analyzer] add-new-checker.py: Introduction

2020-03-12 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso marked an inline comment as done. Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:24 def CoreBuiltin : Package<"builtin">, ParentPackage, Hidden; -def CoreUninitialized : Package<"uninitialized">, ParentPackage; +def

[PATCH] D73521: [analyzer] add-new-checker.py: Introduction

2020-03-12 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso updated this revision to Diff 250020. Charusso marked 3 inline comments as done. Charusso retitled this revision from "[analyzer][WIP] add-new-checker.py: Introduction" to "[analyzer] add-new-checker.py: Introduction". Charusso added a comment. Herald added a subscriber: mgorny. - Try to