Charusso updated this revision to Diff 248110.
Charusso marked 4 inline comments as done.
Charusso added a comment.
Herald added subscribers: martong, steakhal.
- Make the tags robust and more unique.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73520/new/
https://reviews.llvm.org/D735
Charusso added inline comments.
Comment at:
clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:44
-/// BugReporterVisitors are used to add custom diagnostics along a path.
+/// BugReporterVisitors are used to add custom diagnostics along a \emoji bug
+//
Szelethus added a comment.
Thanks! Bug report generation seems far less of a mess than is used to be :)
Comment at:
clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:44
-/// BugReporterVisitors are used to add custom diagnostics along a path.
+/// Bug
NoQ added inline comments.
Comment at:
clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:195
+
+ static const char *getTag() { return "FindLastStore"; }
+
Charusso wrote:
> I have made every tag a small-string.
This way it's harder to be
Charusso marked 2 inline comments as done.
Charusso added inline comments.
Comment at:
clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:195
+
+ static const char *getTag() { return "FindLastStore"; }
+
I have made every tag a small-stri
Charusso created this revision.
Charusso added a reviewer: NoQ.
Charusso added a project: clang.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus,
mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun.
-
Repository:
rC Clang
https://reviews.llvm.org/D73520
Fi
