[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

This revision was automatically updated to reflect the committed changes. antiagainst marked an inline comment as done. Closed by commit rGdf71000d7d5d: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops (authored by antiagainst). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst marked 4 inline comments as done. antiagainst added inline comments. Comment at: mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRV.cpp:125 + +PatternMatchResult SingleWorkgroupReduction::matchAndRewrite( +linalg::GenericOp genericOp, ArrayRef operands, -

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

nicolasvasilache accepted this revision. nicolasvasilache added a comment. This revision is now accepted and ready to land. Herald added a subscriber: Joonsoo. Thanks Lei, this looks great, glad to see you pushing on this front! Comment at: mlir/lib/Conversion/LinalgToSPIRV/Lin

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62199 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `gi

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst updated this revision to Diff 241431. antiagainst marked 16 inline comments as done. antiagainst added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73437/new/ https://reviews.llvm.org/D73437 Files: mlir/i

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst added inline comments. Comment at: mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRV.cpp:182 + // Perform the group reduction operation. + Value groupOperation = rewriter.create( + loc, originalInputType.getElementType(), spirv::Scope::Subgroup,

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

mravishankar accepted this revision. mravishankar marked 2 inline comments as done. mravishankar added inline comments. Comment at: mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRV.cpp:73 + + using mlir::matchers::m_Val; + auto a = m_Val(block.getArgument(0)); m

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

mravishankar marked an inline comment as done. mravishankar added inline comments. Comment at: mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRV.cpp:73 + + using mlir::matchers::m_Val; + auto a = m_Val(block.getArgument(0)); antiagainst wrote: > mravishankar wrot

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

nicolasvasilache requested changes to this revision. nicolasvasilache added inline comments. This revision now requires changes to proceed. Comment at: mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRV.cpp:27 +/// types. +static bool areAllValuesMemref(Operation *op) { + auto isOf

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

rriddle added inline comments. Comment at: mlir/include/mlir/Dialect/SPIRV/SPIRVControlFlowOps.td:463 +Location loc, Value condition, +llvm::function_ref thenBody, +OpBuilder *builder); Drop the llvm::. Comment at: mlir/

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62199 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62199 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `gi

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst added a comment. Messed up the revision history with Arc... Please show the diff between "Diff 1" and "Diff 4" to check the modifications. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73437/new/ https://reviews.llvm.org/D73437

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst updated this revision to Diff 240861. antiagainst added a comment. Clean up unrelated commits again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73437/new/ https://reviews.llvm.org/D73437 Files: mlir/include/mlir/Conversion/LinalgTo

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst marked 2 inline comments as done. antiagainst added inline comments. Herald added a reviewer: mclow.lists. Comment at: mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRV.cpp:27 +/// types. +static inline bool areAllValuesMemref(Operation *op) { + auto isOfMemrefType = [