[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

Szelethus added a comment. Herald added subscribers: ASDenysPetrov, martong. Documentation under `clang/docs/analyzer/checkers.rst` seems to be missing. Could we get that fixed before 11.0.0 releases? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4c26d993bdc: [analyzer] Add FuchsiaLockChecker and C11LockChecker (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D73376?vs=240650&id=240678#toc Repository: rG LLVM Github

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. LGTM!~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73376/new/ https://reviews.llvm.org/D73376 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

xazax.hun updated this revision to Diff 240650. xazax.hun added a comment. - Add a FIXME. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73376/new/ https://reviews.llvm.org/D73376 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/lib/StaticAnalyzer/Checkers/Pthrea

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

NoQ added inline comments. Comment at: clang/test/Analysis/c11lock.c:7 +enum { + thrd_success = 0, + thrd_error = 2 xazax.hun wrote: > Strictly speaking, this is implementation defined. But the C11 > implementations I am aware of are following this trend (`thr

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

xazax.hun marked 2 inline comments as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/c11lock.c:7 +enum { + thrd_success = 0, + thrd_error = 2 Strictly speaking, this is implementation defined. But the C11 implementations I am aware of a

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

xazax.hun added a comment. In D73376#1839818 , @NoQ wrote: > I don't see any immediate solutions to the boilerplate that don't consist in > introducing better checker APIs. Eg., we could have introduced a > `LazyBugType` - a wrapper around `Optional` tha

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

xazax.hun updated this revision to Diff 240624. xazax.hun marked 2 inline comments as done. xazax.hun added a comment. - Add more tests. - Move the C11 checker to alpha.core CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73376/new/ https://reviews.llvm.org/D73376 Files: clang/include/

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/c11lock.c:1 +// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.unix.C11Lock -verify %s + NoQ wrote: > NoQ wrote: > > I wouldn't mind `alpha.core` given t

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

NoQ added inline comments. Comment at: clang/test/Analysis/c11lock.c:1 +// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.unix.C11Lock -verify %s + NoQ wrote: > I wouldn't mind `alpha.core` given that these functions belong to the > standard library. (i.e., i m

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

NoQ added a comment. Yay, C11 as well!! > If you have any idea how to reduce this boilerplate I'd like to know :) I don't see any immediate solutions to the boilerplate that don't consist in introducing better checker APIs. Eg., we could have introduced a `LazyBugType` - a wrapper around `Opti

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

xazax.hun created this revision. xazax.hun added reviewers: NoQ, haowei. xazax.hun added a project: clang. Herald added subscribers: Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, jfb, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Basically, the semantics of C11 and Fuchs