[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

2020-01-27 Thread Bill Wendling via Phabricator via cfe-commits
void abandoned this revision. void added a comment. I'm going to merge this into D69876 as it's closely related. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73319/new/ https://reviews.llvm.org/D73319

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

2020-01-27 Thread Bill Wendling via Phabricator via cfe-commits
void marked an inline comment as done. void added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1273 + int y; + asm goto("# %0 %1 %2" : "=r"(y) : "r"(x) : : err); + return y; MaskRay wrote: > Is the canonical spelling `%l2`? Nice c

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

2020-01-27 Thread Bill Wendling via Phabricator via cfe-commits
void marked an inline comment as done. void added a comment. In D73319#1843129 , @nickdesaulniers wrote: > In D73319#1842951 , @void wrote: > > > In D73319#1842900 , > > @n

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

2020-01-27 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1273 + int y; + asm goto("# %0 %1 %2" : "=r"(y) : "r"(x) : : err); + return y; Is the canonical spelling `%l2`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

2020-01-27 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. In D73319#1842951 , @void wrote: > In D73319#1842900 , @nickdesaulniers > wrote: > > > Great idea; thanks for the patch! Needs documentation. :) > > > I can't find a place for docum

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

2020-01-27 Thread Bill Wendling via Phabricator via cfe-commits
void updated this revision to Diff 240681. void added a comment. Add description of "gnu_asm_goto_with_outputs" to the language extensions doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73319/new/ https://reviews.llvm.org/D73319 Files: clang

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

2020-01-27 Thread Bill Wendling via Phabricator via cfe-commits
void updated this revision to Diff 240663. void marked 2 inline comments as done. void added a comment. Move extension test to exsiting test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73319/new/ https://reviews.llvm.org/D73319 Files: clang/i

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

2020-01-27 Thread Bill Wendling via Phabricator via cfe-commits
void added a comment. In D73319#1842900 , @nickdesaulniers wrote: > Great idea; thanks for the patch! Needs documentation. :) I can't find a place for documentation of extensions, at least not the names of extensions like `gnu_asm`.

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

2020-01-27 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. Great idea; thanks for the patch! Needs documentation. :) Comment at: clang/test/Parser/asm-goto-with-outputs.c:7 +#error Extension 'gnu_asm_goto_with_outputs' should be available by default +#endif + probably don't need a bunch

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

2020-01-27 Thread Bill Wendling via Phabricator via cfe-commits
void updated this revision to Diff 240657. void added a comment. Use GNU asm predicate for the "asm goto with outputs" extension. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73319/new/ https://reviews.llvm.org/D73319 Files: clang/include/clang

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

2020-01-23 Thread Bill Wendling via Phabricator via cfe-commits
void created this revision. void added a reviewer: nickdesaulniers. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang now supports GNU's asm goto with outputs. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73319 Files: clang/include/clang/Basic/Fe