[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

2020-01-29 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin added a comment. @thakis I'm sorry sorry if it was not clear. Please let me know if you still prefer to have separate directory for clangTidyMain to have only one target per CMakeLists.txt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

2020-01-27 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin marked an inline comment as done. DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/CMakeLists.txt:22 + clangToolingCore + ) + thakis wrote: > Normally we have a single cmake target per CMakeLists.txt. Maybe the

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

2020-01-27 Thread Nico Weber via Phabricator via cfe-commits
thakis added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/CMakeLists.txt:22 + clangToolingCore + ) + Normally we have a single cmake target per CMakeLists.txt. Maybe the library could be in clang-tidy/lib and clang-tidy/tool could use it? The

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

2020-01-24 Thread Dmitry Polukhin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3f8b100e94b5: [clang-tidy] Add library for clang-tidy main function (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73300/new/ h

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

2020-01-24 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin updated this revision to Diff 240241. DmitryPolukhin added a comment. Added #include "ClangTidyMain.h" in ClangTidyMain.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73300/new/ https://reviews.llvm.org/D73300 Files: clang-tool

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

2020-01-24 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin updated this revision to Diff 240233. DmitryPolukhin added a comment. Updated comment per review suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73300/new/ https://reviews.llvm.org/D73300 Files: clang-tools-extra/clang-t

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

2020-01-24 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added a reviewer: gribozavr2. gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.h:9 +/// +/// \file This file declares clang-tidy tool main

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

2020-01-23 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin marked 2 inline comments as done. DmitryPolukhin added a comment. @Eugene.Zelenko thank you for the catch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73300/new/ https://reviews.llvm.org/D73300 ___

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

2020-01-23 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin updated this revision to Diff 240025. DmitryPolukhin added a comment. Fix license text Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73300/new/ https://reviews.llvm.org/D73300 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.tx

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

2020-01-23 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.h:5 +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. License seems to be old. ==

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

2020-01-23 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin created this revision. DmitryPolukhin added reviewers: smeenai, gribozavr, stephanemoore. DmitryPolukhin added projects: clang-tools-extra, clang. Herald added subscribers: xazax.hun, mgorny. This library allows to create clang-tidy tools with custom checks outside of llvm repo usi