[PATCH] D73299: [HIP] Fix environment variable HIP_DEVICE_LIB_PATH

yaxunl added a comment. In D73299#1845162 , @thakis wrote: > This breaks check-clang on Windows: http://45.33.8.238/win/6843/step_7.txt > > You probably want "env FOO=bar" instead of "FOO=bar" in the test file. Fixed. Thanks. Repository: rG LLVM Gith

[PATCH] D73299: [HIP] Fix environment variable HIP_DEVICE_LIB_PATH

thakis added a comment. This breaks check-clang on Windows: http://45.33.8.238/win/6843/step_7.txt You probably want "env FOO=bar" instead of "FOO=bar" in the test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73299/new/ https://reviews.llvm

[PATCH] D73299: [HIP] Fix environment variable HIP_DEVICE_LIB_PATH

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7e415f37f38: [HIP] Fix environment variable HIP_DEVICE_LIB_PATH (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D73299: [HIP] Fix environment variable HIP_DEVICE_LIB_PATH

yaxunl updated this revision to Diff 240074. yaxunl edited the summary of this revision. yaxunl added a comment. Revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73299/new/ https://reviews.llvm.org/D73299 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp c

[PATCH] D73299: [HIP] Fix environment variable HIP_DEVICE_LIB_PATH

tra added a comment. > If user sets HIP_DEVICE_LIB_PATH, this line in HIP.cpp > addDirectoryList(DriverArgs, LibraryPaths, "-L", "HIP_DEVICE_LIB_PATH"); > adds -L to LibraryPaths. -L is > needed since otherwise addDirectoryList will insert an extra empty string. > However, the -L must be strip

[PATCH] D73299: [HIP] Fix environment variable HIP_DEVICE_LIB_PATH

yaxunl created this revision. yaxunl added a reviewer: tra. If user sets HIP_DEVICE_LIB_PATH, this line in HIP.cpp addDirectoryList(DriverArgs, LibraryPaths, "-L", "HIP_DEVICE_LIB_PATH"); adds `-L` to LibraryPaths. `-L` is needed since otherwise addDirectoryList will insert an extra empty string.