[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

This revision was automatically updated to reflect the committed changes. kadircet marked 2 inline comments as done. Closed by commit rG42e9478e0bbb: [clang][CodeComplete] Support for designated initializers (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62159 tests passed, 5 failed and 811 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

kadircet marked 7 inline comments as done. kadircet added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2463 +PreferredType.enterVariableInit(Tok.getLocation(), ThisDecl); ExprResult Init(ParseBraceInitializer()); sammccall wrote: > oops,

[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

kadircet updated this revision to Diff 240551. kadircet marked 7 inline comments as done. kadircet added a comment. - Propogate types in more cases - Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73271/new/ https://reviews.llvm.org/D

[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

sammccall added a comment. oops, needs some more tests. Comment at: clang/lib/Parse/ParseDecl.cpp:2463 +PreferredType.enterVariableInit(Tok.getLocation(), ThisDecl); ExprResult Init(ParseBraceInitializer()); oops, I missed where this was happening.

[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nit: maybe mention "top-level" in the patch? Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4731 +static RecordDecl *getAsRecordDecl(const QualType BaseType) { + i

[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62138 tests passed, 0 failed and 808 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73271 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/Sema.h clang