[PATCH] D73202: Make AST reading work better with LLVM_APPEND_VC_REV=NO

2020-01-27 Thread Nico Weber via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG49532137d087: Make AST reading work better with LLVM_APPEND_VC_REV=NO (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D73202: Make AST reading work better with LLVM_APPEND_VC_REV=NO

2020-01-27 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73202/new/ https://reviews.llvm.org/D73202 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D73202: Make AST reading work better with LLVM_APPEND_VC_REV=NO

2020-01-27 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. rnk, could you maybe take a look? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73202/new/ https://reviews.llvm.org/D73202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D73202: Make AST reading work better with LLVM_APPEND_VC_REV=NO

2020-01-22 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added reviewers: saar.raz, rsmith. thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3645 // CityHash, but this will do for now. hash_code code = hash_value(getCl

[PATCH] D73202: Make AST reading work better with LLVM_APPEND_VC_REV=NO

2020-01-22 Thread Nico Weber via Phabricator via cfe-commits
thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3645 // CityHash, but this will do for now. hash_code code = hash_value(getClangFullRepositoryVersion()); Arguably, we should omit