[PATCH] D73166: [ASTImporter] Properly delete decls from SavedImportPaths

2020-01-22 Thread Raphael Isemann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4481eefbe842: [ASTImporter] Properly delete decls from SavedImportPaths (authored by jarin, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D73166: [ASTImporter] Properly delete decls from SavedImportPaths

2020-01-22 Thread Raphael Isemann via Phabricator via cfe-commits
teemperor added a comment. I can land it, seems to pass all LLDB tests too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73166/new/ https://reviews.llvm.org/D73166 ___ cfe-commits mailing list cfe-com

[PATCH] D73166: [ASTImporter] Properly delete decls from SavedImportPaths

2020-01-22 Thread Jaroslav Sevcik via Phabricator via cfe-commits
jarin added a comment. Thanks for the review! I am not a committer; could you land the fix for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73166/new/ https://reviews.llvm.org/D73166 ___ cfe-comm

[PATCH] D73166: [ASTImporter] Properly delete decls from SavedImportPaths

2020-01-22 Thread Gabor Marton via Phabricator via cfe-commits
martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks for the fix! Looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73166/new/ https://reviews.llvm.org/D73166

[PATCH] D73166: [ASTImporter] Properly delete decls from SavedImportPaths

2020-01-22 Thread Jaroslav Sevcik via Phabricator via cfe-commits
jarin created this revision. jarin added reviewers: martong, teemperor. Herald added subscribers: cfe-commits, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. We see a significant regression (~40% slower on large codebases) in expressio