This revision was automatically updated to reflect the committed changes.
Closed by commit rG0957233320eb: [Alignment][NFC] Use Align with
CreateMaskedStore (authored by gchatelet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73106/new/
https://re
gchatelet marked an inline comment as done.
gchatelet added inline comments.
Comment at: llvm/docs/LangRef.rst:14945
-The first operand is the base pointer for the load. The second operand is the
alignment of the source location. It must be a constant integer value. The
third
gchatelet updated this revision to Diff 239513.
gchatelet marked an inline comment as done.
gchatelet added a comment.
- Reverting LangRef
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73106/new/
https://reviews.llvm.org/D73106
Files:
clang/lib/
courbet accepted this revision.
courbet added inline comments.
This revision is now accepted and ready to land.
Comment at: llvm/docs/LangRef.rst:14945
-The first operand is the base pointer for the load. The second operand is the
alignment of the source location. It must be a
gchatelet marked 2 inline comments as done.
gchatelet added inline comments.
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:2907
Value *Addr = I.getArgOperand(1);
-const MaybeAlign Alignment(
+const Align Alignment(
cast(I.getArgOperand(
gchatelet updated this revision to Diff 239501.
gchatelet marked an inline comment as done.
gchatelet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73106/new/
https://reviews.llvm.org/D73106
Files:
clang/lib/C
courbet added inline comments.
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:2907
Value *Addr = I.getArgOperand(1);
-const MaybeAlign Alignment(
+const Align Alignment(
cast(I.getArgOperand(2))->getZExtValue());
I think
gchatelet created this revision.
gchatelet added a reviewer: courbet.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya.
Herald added projects: clang, LLVM.
This is patch is part of a series to introduce an Alignment type.
See this thread for context:
http://lists.llvm.org/pipermail/
