rsmith added a comment.
We're working on moving the parent map out of `ASTContext` and into something
specific to tooling; please don't add more dependencies onto it in the AST
library.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73029/new/
htt
aaron.ballman added a comment.
Test cases?
Comment at: clang/lib/AST/ASTContext.cpp:1066
+if (Node.getNodeKind().hasPointerIdentity()) {
+ auto ParentList =
+ getDynNodeFromMap(Node.getMemoizationData(), PointerParents);
Please spell the type
steveire updated this revision to Diff 239075.
steveire added a comment.
Format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73029/new/
https://reviews.llvm.org/D73029
Files:
clang/include/clang/AST/ASTContext.h
clang/include/clang/AST/ExprTr
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This allows ASTContext to store only one parent map, rather than storing
an entire parent map for each traversal mode used.
This is therefore a partial