[PATCH] D72903: [HIP] use GetProgramPath for executable discovery

hans added a comment. In D72903#1832070 , @yaxunl wrote: > Sorry for the delay. I have no objection to cherrypick this change to release > 10. Thanks. I've cherry-picked it as 3cce3790072249cbe51b96cea26bc78019c11fd0

[PATCH] D72903: [HIP] use GetProgramPath for executable discovery

yaxunl added a comment. Sorry for the delay. I have no objection to cherrypick this change to release 10. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72903/new/ https://reviews.llvm.org/D72903 _

[PATCH] D72903: [HIP] use GetProgramPath for executable discovery

DieGoldeneEnte added a comment. Thanks @tra! @hans: I would leave the decision to cherry-pick this into the 10 release to you. I think the change is nice to have, but once you know the problem, there exists an easy workaround (like symlinking the executables to the right directory). Reposito

[PATCH] D72903: [HIP] use GetProgramPath for executable discovery

hans added a comment. In D72903#1831716 , @tra wrote: > I've landed the change. As for backporting, I'll leave it up to AMD folks. If > @yaxunl and the team deem it appropriate, they should talk to @hans about > cherry-picking the change into particular

[PATCH] D72903: [HIP] use GetProgramPath for executable discovery

tra added a subscriber: hans. tra added a comment. I've landed the change. As for backporting, I'll leave it up to AMD folks. If @yaxunl and the team deem it appropriate, they should talk to @hans about cherry-picking the change into particular releases. Repository: rG LLVM Github Monorepo

[PATCH] D72903: [HIP] use GetProgramPath for executable discovery

This revision was automatically updated to reflect the committed changes. Closed by commit rG24d7a0935bea: [HIP] use GetProgramPath for executable discovery (authored by DieGoldeneEnte, committed by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D72903: [HIP] use GetProgramPath for executable discovery

DieGoldeneEnte added a comment. If @yaxunl has no objections, could someone merge this as I don't have commit access? Also do we want to also apply this to older versions, since the change is trivial? I confirmed the same problem is in clang 8, 9 and 10 and am certain it is in clang 7, although

[PATCH] D72903: [HIP] use GetProgramPath for executable discovery

DieGoldeneEnte created this revision. DieGoldeneEnte added reviewers: yaxunl, tra. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change replaces the manual building of executable paths using llvm::sys::path::append with GetProgramPath. This enables adding other paths