[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

This revision was automatically updated to reflect the committed changes. Closed by commit rGd293417931d3: Add __warn_memset_zero_len builtin as a workaround for glibc issue (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

efriedma added a comment. We currently don't have any mechanism for restricting builtins to specific operating systems. I guess we could add one, but this change doesn't seem like a compelling argument to add that capability. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

joerg added a comment. Can this be restricted to Linux? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72869/new/ https://reviews.llvm.org/D72869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61934 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

akhuang added a comment. In D72869#1824927 , @serge-sans-paille wrote: > @akhuang can you confirm this fixes your issue? I've tested locally and it > works fine on my side. Yes, this fixes the __warn_memset_zero_len issue, thanks! Repository: rG LL

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72869/new/ https://reviews.llvm.org/D72869 ___

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

serge-sans-paille updated this revision to Diff 238614. serge-sans-paille added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72869/new/ https://reviews.llvm.org/D72869 Files: clang/include/clang/Basic/Builtins.def cla

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

serge-sans-paille added a comment. In D72869#1824951 , @efriedma wrote: > This is very hacky, Yeah, I know... > but it might be the least-bad alternative. I mean, we could change D71082 > so it doesn't allow system he

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61933 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

efriedma added a comment. This is very hacky, but it might be the least-bad alternative. I mean, we could change D71082 so it doesn't allow system headers to define memset, but that seems worse. Please add a testcase. Repository: rG LLVM Github Monorepo C

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

serge-sans-paille created this revision. serge-sans-paille added reviewers: rnk, george.burgess.iv, akhuang. Herald added a project: clang. Herald added a subscriber: cfe-commits. serge-sans-paille added a comment. @akhuang can you confirm this fixes your issue? I've tested locally and it works f

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

serge-sans-paille added a comment. @akhuang can you confirm this fixes your issue? I've tested locally and it works fine on my side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72869/new/ https://reviews.llvm.org/D72869 __