hans added inline comments.
Comment at: clang/lib/Basic/Version.cpp:33
#else
- StringRef URL("");
+ return "";
#endif
Eugene.Zelenko wrote:
> hans wrote:
> > Eugene.Zelenko wrote:
> > > return {} should be better.
> > Why? I think "" is clearer for a string.
Eugene.Zelenko added inline comments.
Comment at: clang/lib/Basic/Version.cpp:33
#else
- StringRef URL("");
+ return "";
#endif
hans wrote:
> Eugene.Zelenko wrote:
> > return {} should be better.
> Why? I think "" is clearer for a string.
It's default non-tri
hans added inline comments.
Comment at: clang/lib/Basic/Version.cpp:33
#else
- StringRef URL("");
+ return "";
#endif
Eugene.Zelenko wrote:
> return {} should be better.
Why? I think "" is clearer for a string.
Repository:
rG LLVM Github Monorepo
CHANGES
Eugene.Zelenko added inline comments.
Comment at: clang/lib/Basic/Version.cpp:33
#else
- StringRef URL("");
+ return "";
#endif
return {} should be better.
Comment at: clang/lib/Basic/Version.cpp:42
#else
- StringRef URL("");
+ return ""
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfb9413cb84cc: Remove some SVN-specific code. (authored by
thakis).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72848/new/
h
thakis created this revision.
thakis added a reviewer: hans.
$URL$ is an SVN keyword substitution enabled via
`svn propset svn:keywords "URL" tools/clang/lib/Basic/Version.cpp`.
Now that we no longer use SVN, it's no longer being replaced by
anything, and we no longer offer svn exports. So remove
