[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61912 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

This revision was automatically updated to reflect the committed changes. Closed by commit rGd54d71b67e60: [clangd] Make output order of allTargetDecls deterministic (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72826/new/ ht

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:224 +using ValTy = std::pair; +llvm::SmallVector Result; +for (const auto &Elem : Decls) sammccall wrote: > no need for lookups I think > ``` > Result.resize(Decls.siz

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

kadircet updated this revision to Diff 238469. kadircet marked 3 inline comments as done. kadircet added a comment. - Get rid of redundant sorting step Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72826/new/ https://reviews.llvm.org/D72826 Files:

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:224 +using ValTy = std::pair; +llvm::SmallVector Result; +for (const auto &Elem : Decls) no need for lookups I think ``` Result.resi

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61912 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

kadircet updated this revision to Diff 238456. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72826/new/ https://reviews.llvm.org/D72826 Files: clang-tools-extra/clangd/FindTarget.cpp Index: clang-too

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/FindTarget.cpp:202 +private: + llvm::SmallDenseMap InsertionOrder; llvm::SmallDenseMap Decls; why two maps

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61895 tests passed, 0 failed and 782 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Makes use of insertion order to stabilize output for multiple decls. Fixes https://bugs.llvm.o