pengfei updated this revision to Diff 238417.
pengfei marked an inline comment as done.
pengfei added a comment.
Address review comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72820/new/
https://reviews.llvm.org/D72820
Files:
clang/lib/Co
craig.topper added inline comments.
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7061
+ auto pushOutChain = [this](auto &Result, auto EB) {
+assert(Result.getNode()->getNumValues() == 2);
Why is Result a reference? It's not modified is
pengfei updated this revision to Diff 238414.
pengfei marked an inline comment as done.
pengfei added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72820/new/
https://reviews.llvm.org/D72820
Files:
clang/lib/C
craig.topper added inline comments.
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7064
+
+ auto pushOutChain = [&]() {
+assert(Result.getNode()->getNumValues() == 2);
Can you make the SDValue Result an argument of this and only capture 't
craig.topper added a comment.
The title of this review is misleading. It should at least mention FPEnv,
constrained intrinsics, or strict fp or something. Right now it sounds like
FP_CONTRACT isn't supported at all.
Can we split most of the X86 changes into a separate patch? Most of it can be
pengfei updated this revision to Diff 238408.
pengfei added a comment.
Remove dead code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72820/new/
https://reviews.llvm.org/D72820
Files:
clang/lib/CodeGen/CGExprScalar.cpp
clang/test/CodeGen/cons
pengfei created this revision.
pengfei added reviewers: craig.topper, andrew.w.kaylor, uweigand, RKSimon,
LiuChen3.
Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, hiraditya.
Herald added projects: clang, LLVM.
Support pragma FP_CONTRACT.
Repository:
rG LLVM Github Monorepo
h
