[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7727 +// Move function type attribute to the declarator. +case ParsedAttr::AT_LifetimeContract: xazax.hun wrote: > aaron.ballman wrote: > > xazax.hun wrote: > > > aaron.ballman

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7727 +// Move function type attribute to the declarator. +case ParsedAttr::AT_LifetimeContract: aaron.ballman wrote: > xazax.hun wrote:

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/LifetimeAttr.h:163 +// Maps each annotated entity to a lifetime set. +using LifetimeContracts = std::map; + xazax.hun wrote: > aaron.ballman wrote: > > xazax.hun wrote: > > > gribozavr2 wrot

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

xazax.hun updated this revision to Diff 251569. xazax.hun marked an inline comment as done. xazax.hun added a comment. - Rebase. - Address some review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72810/new/ https://reviews.llvm.org/D72810 Files: clang/include/clang/AST/Att

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

xazax.hun marked 14 inline comments as done. xazax.hun added inline comments. Comment at: clang/include/clang/AST/LifetimeAttr.h:163 +// Maps each annotated entity to a lifetime set. +using LifetimeContracts = std::map; + aaron.ballman wrote: > xazax.hun wrote: >

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

aaron.ballman added a comment. Thank you for the work on this! Comment at: clang/include/clang/AST/LifetimeAttr.h:24 +/// An abstract memory location that participates in defining a lifetime +/// contract. A lifetime contract constrains lifetime of a +/// LifetimeContractVariab

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

xazax.hun updated this revision to Diff 240335. xazax.hun added a comment. - Address some review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72810/new/ https://reviews.llvm.org/D72810 Files: clang/include/clang/AST/Attr.h clang/include/clang/AST/LifetimeAttr.h clang/i

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

xazax.hun marked 14 inline comments as done. xazax.hun added inline comments. Comment at: clang/include/clang/AST/LifetimeAttr.h:163 +// Maps each annotated entity to a lifetime set. +using LifetimeContracts = std::map; + gribozavr2 wrote: > Generally, DenseMap a

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at: clang/include/clang/AST/LifetimeAttr.h:22 + +/// This represents an abstract memory location that is used in the lifetime +/// contract representation. gribozavr2 wrote: >

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

xazax.hun marked 6 inline comments as done. xazax.hun added inline comments. Comment at: clang/include/clang/AST/LifetimeAttr.h:143 +using LifetimeContractSet = std::set; +using LifetimeContractMap = std::map; + gribozavr2 wrote: > These names are not descriptive

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

xazax.hun updated this revision to Diff 239644. xazax.hun marked 10 inline comments as done. xazax.hun added a comment. - Address most of the review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72810/new/ https://reviews.llvm.org/D72810 Files: clang/include/clang/AST/Attr.

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

gribozavr2 added a comment. I'd also appreciate if you updated the docs for the changes done in this patch. Comment at: clang/include/clang/AST/LifetimeAttr.h:22 + +/// This represents an abstract memory location that is used in the lifetime +/// contract representation. --

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

xazax.hun created this revision. xazax.hun added reviewers: mgehre, ymandel, gribozavr2, aaron.ballman, rsmith, rjmccall. xazax.hun added a project: clang. Herald added subscribers: Szelethus, Charusso, gamesh411, dkrupp, rnkovacs, mgorny. This patch corresponds to this RFC: http://lists.llvm.o