[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

2020-01-14 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Ah, I'll want to figure out how to emit local aliases to dso_local as a follow-up of D72197 , but that should be orthogonal to what you want to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

2020-01-14 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61856 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

2020-01-14 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D72724#1820392 , @serge-sans-paille wrote: > @MaskRay: is that okay with you if I start implementing > -fsemantic-interposition based on `dso_preemptable`? I haven't done anything in this area. Go ahead:) I'd like to help or

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

2020-01-14 Thread Fangrui Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5d1b3ba68769: [Driver] Ignore -fno-semantic-interposition (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72724/new/ https://reviews.ll

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

2020-01-14 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D72724#1820362 , @serge-sans-paille wrote: > LGTM I don't follow Fedora news. It is just that a friend informed me of this -fno-semantic-interposition movement two days ago and I postulated that it was your motivation to pi

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

2020-01-14 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. @MaskRay: is that okay with you if I start implementing -fsemantic-interposition based on `dso_preemptable`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72724/new/ https://reviews.llvm.org/D72724 ___

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

2020-01-14 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 238065. MaskRay added a comment. Use Flag<> instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72724/new/ https://reviews.llvm.org/D72724 Files: clang/include/clang/Driver/Options.td clang/test/Driver/c

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

2020-01-14 Thread serge via Phabricator via cfe-commits
serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72724/new/ https://reviews.llvm.org/D72724 _

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

2020-01-14 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61849 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72724: [Driver] Ignore -fno-semantic-interposition

2020-01-14 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: hfinkel, tstellar, Romain-Geissler-1A, serge-sans-paille. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fedora wants to build projects with -fno-semantic-interposition (e.g. https://fedoraproject.org/wiki/Changes/Pyt