erichkeane marked an inline comment as done.
erichkeane added inline comments.
Comment at: clang/lib/Sema/SemaExceptionSpec.cpp:90-92
+llvm::APSInt Value{1};
+Value = 0;
+return ConstantExpr::Create(Context, BoolExpr, APValue{Value});
aaron.ballman wr
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf0719bf2196c: PR44514: Fix recovery from noexcept with
non-convertible expressions (authored by erichkeane).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a simplification. Can you mention the LLVM bug report in the
commit log, as well (and close the bug)?
Comment at: clang/lib/Sema/SemaExceptionS
erichkeane created this revision.
erichkeane added a reviewer: aaron.ballman.
Herald added a project: clang.
We currently treat noexcept(not-convertible-to-bool) as 'none', which
results in the typeloc info being a different size, and causing an
assert later on in the process. In order to make re
