[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

lebedev.ri added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:199-202 +- New alias :doc:`performance-prefer-pre-increment + ` to + :doc:`llvm-prefer-pre-increment + ` was added. njames93 wrote: > lebedev.ri wrote: > > Are we **really**

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:199-202 +- New alias :doc:`performance-prefer-pre-increment + ` to + :doc:`llvm-prefer-pre-increment + ` was added. lebedev.ri wrote:

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61861 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

lebedev.ri added a comment. Happy to see this check! Comment at: clang-tools-extra/docs/ReleaseNotes.rst:199-202 +- New alias :doc:`performance-prefer-pre-increment + ` to + :doc:`llvm-prefer-pre-increment + ` was added. Are we **really** **really** sure thi

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 updated this revision to Diff 238082. njames93 added a comment. - fix spelling mistake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files: clang-tools-extra/clang-tidy/llvm/CMakeLists.txt cl

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61775 tests passed, 0 failed and 780 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 updated this revision to Diff 237517. njames93 added a comment. - Rebased onto trunk fixing merge issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files: clang-tools-extra/clang-tidy/llvm/C

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 updated this revision to Diff 237505. njames93 added a comment. - Fix perf alias documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files: clang-tools-extra/clang-tidy/llvm/CMakeLists.

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

Mordante added a comment. In D72553#1815558 , @njames93 wrote: > - 99% sure I have all incriments renamed now I checked and can't find them anymore, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-prefer-pre-increment.rst:8 + +The cert-oop54-cpp check is an alias, please see +`llvm-prefer-pre-increment `_ Please fix check name. Repository: rG LLVM Gi

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 updated this revision to Diff 237502. njames93 added a comment. - 99% sure I have all incriments renamed now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files: clang-tools-extra/clang-tidy/ll

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/PreferPreincrementCheck.cpp:38 + // returned. Reordering those would change the behaviour of the expression. + // FIXME: Add any more parents which could use the result of the operation. + auto BadPa

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 updated this revision to Diff 237500. njames93 added a comment. - Renamed incriment in test cases to increment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files: clang-tools-extra/clang-tidy/

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 updated this revision to Diff 237499. njames93 marked 2 inline comments as done. njames93 added a comment. - Added alias for performance module - renamed check to prefer-pre-increment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

Mordante added a comment. I only have some naming nits - incriment -> increment - decriment -> decrement Maybe rename the check llvm-prefer-preincrement -> llvm-prefer-pre-increment and rename the files and classes PreferPreincrementCheck -> PreferPreIncrementCheck Comment a

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

Eugene.Zelenko added a comment. In D72553#1815497 , @njames93 wrote: > could this do with an alias into performance? Sure. At least such tricky questions were asked on interviews decade ago :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 marked an inline comment as done. njames93 added a comment. could this do with an alias into performance? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 _

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 updated this revision to Diff 237490. njames93 added a comment. - Small refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files: clang-tools-extra/clang-tidy/llvm/CMakeLists.txt clang-to

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

Eugene.Zelenko added a comment. It'll be reasonable to submit patches generated by check into trunk. May be after branching release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 __

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/llvm-prefer-preincrement.rst:30 + both the prefix and postfix operator ``++`` or ``--``. + Default value is 1. + Please highlight default value with single back-ticks.

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, hokein. njames93 added projects: clang, clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a new clang-tidy check that detects postfix increments and decrements that can be swapped for their prefix