[PATCH] D72375: Disallow an empty string literal in an asm label

2020-01-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. Accepting based on @rjmccall's LG so I can close. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72375/new/ https://reviews.llvm.org/D72375 ___ cfe-commits mailing list cfe

[PATCH] D72375: Disallow an empty string literal in an asm label

2020-01-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Committed in 55a51e1c79a21080289ba88d5eac4bbe54ec4272 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72375/new/ https://reviews.llvm.org/D72375 ___

[PATCH] D72375: Disallow an empty string literal in an asm label

2020-01-07 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72375/new/ https://reviews.llvm.org/D72375 ___ cfe-commits mailing list cfe-commi

[PATCH] D72375: Disallow an empty string literal in an asm label

2020-01-07 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: rjmccall, joerg, eli.friedman. An empty string literal in an asm label does not make a whole lot of sense. GCC does not diagnose such a construct, but it also generates code that cannot be assembled by gas should two symbols hav