[PATCH] D72274: [libTooling] Fix bug in Stencil handling of macro ranges

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9d2bf38e86e: [libTooling] Fix bug in Stencil handling of macro ranges (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72274/new/ https

[PATCH] D72274: [libTooling] Fix bug in Stencil handling of macro ranges

ymandel marked an inline comment as done. ymandel added a comment. Thanks for the review! In D72274#1826634 , @gribozavr2 wrote: > In D72274#1826614 , @ymandel wrote: > > > In D72274#1826477

[PATCH] D72274: [libTooling] Fix bug in Stencil handling of macro ranges

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. In D72274#1826614 , @ymandel wrote: > In D72274#1826477 , @gribozavr2 > wrote: > > > The only function

[PATCH] D72274: [libTooling] Fix bug in Stencil handling of macro ranges

ymandel marked 2 inline comments as done. ymandel added a comment. In D72274#1826477 , @gribozavr2 wrote: > The only functional change that I see in this patch is in > `clang/lib/Tooling/Transformer/Stencil.cpp`. However, I don't understand how > that ch

[PATCH] D72274: [libTooling] Fix bug in Stencil handling of macro ranges

gribozavr2 added a comment. The only functional change that I see in this patch is in `clang/lib/Tooling/Transformer/Stencil.cpp`. However, I don't understand how that change in the (deprecated) selection() stencil can affect other stencils. Comment at: clang/unittests/Toolin

[PATCH] D72274: [libTooling] Fix bug in Stencil handling of macro ranges

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. Currently, an attempt to rewrite source code inside a macro expansion succeeds, but results in empty text, rather than failing with an error. This patch restructures to the code to explicitly vali