[PATCH] D72144: Treat C# `using` as a control statement

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rG1e0174a93cfd: Treat C# `using` as a control statement (authored by krasimir). Repository: rG LLVM Github Monorepo CH

[PATCH] D72144: Treat C# `using` as a control statement

krasimir accepted this revision. krasimir added a comment. I'll submit this for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72144/new/ https://reviews.llvm.org/D72144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D72144: Treat C# `using` as a control statement

krasimir requested changes to this revision. krasimir added a comment. This revision now requires changes to proceed. I looked up the C# reference and all the examples are top-level, so having top-level

[PATCH] D72144: Treat C# `using` as a control statement

jbcoe updated this revision to Diff 239836. jbcoe added a comment. Extended tests and added some comments explaining why seeming duplicated tests are useful. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72144/new/ https://reviews.llvm.org/D72144 Files: clang/lib/Format/TokenAnnotat

[PATCH] D72144: Treat C# `using` as a control statement

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. In D72144#1834265 , @jbcoe wrote: > Removed test snippets that did not exercise new code. Actually i would prefer we didn't

[PATCH] D72144: Treat C# `using` as a control statement

jbcoe updated this revision to Diff 239629. jbcoe added a comment. Removed test snippets that did not exercise new code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72144/new/ https://reviews.llvm.org/D72144 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/Format

[PATCH] D72144: Treat C# `using` as a control statement

krasimir accepted this revision. krasimir added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:259 + + verifyFormat("using (StreamWriter sw = new StreamWriter(filenameB)) {}", + Style);

[PATCH] D72144: Treat C# `using` as a control statement

jbcoe marked 2 inline comments as done. jbcoe added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:259 + + verifyFormat("using (StreamWriter sw = new StreamWriter(filenameB)) {}", + Style); krasimir wrote: > Can this appea

[PATCH] D72144: Treat C# `using` as a control statement

jbcoe updated this revision to Diff 239574. jbcoe added a comment. Handle `using` case where SpaceBeforeParensOptions is set to SBPO_NonEmptyParentheses CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72144/new/ https://reviews.llvm.org/D72144 Files: clang/lib/Format/TokenAnnotator.cp

[PATCH] D72144: Treat C# `using` as a control statement

krasimir requested changes to this revision. krasimir added inline comments. This revision now requires changes to proceed. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:257 + "}", + Style); + Please also add a test for `SBPO

[PATCH] D72144: Treat C# `using` as a control statement

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72144/new/ https://reviews.llvm.org/D72144 ___ cfe-commits mailing li

[PATCH] D72144: Treat C# `using` as a control statement

jbcoe updated this revision to Diff 236035. jbcoe added a reviewer: klimek. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72144/new/ https://reviews.llvm.org/D72144 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTestCSharp.cpp Index: clang/unittests/Format/

[PATCH] D72144: Treat C# `using` as a control statement

jbcoe created this revision. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Unless SpaceBeforeParensOptions is set to SBPO_Never, a space will be put between `using` and `(` in C# code. Repository: rG LLVM Github Monorepo https://r