[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

This revision was automatically updated to reflect the committed changes. Closed by commit rG2af74e27ed7d: [MS] Overhaul how clang passes overaligned args on x86_32 (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72114/new/ https://

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72114/new/ https://reviews.llvm.org/D72114 ___

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rjmccall added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:91 bool InAllocaSRet : 1;// isInAlloca() + bool InAllocaIndirect : 1;// isInAlloca() bool IndirectByVal : 1; // isIndirect() rnk wrote: > rjmccall wrote: > > rnk

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61871 tests passed, 1 failed and 781 were skipped. failed: Clang.PCH/ms-pch-macro.c {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your ch

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rnk updated this revision to Diff 238152. rnk marked 2 inline comments as done. rnk added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72114/new/ https://reviews.llvm.org/D72114 Files: clang/include/clang/CodeGen/CGFunctionI

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rnk added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:91 bool InAllocaSRet : 1;// isInAlloca() + bool InAllocaIndirect : 1;// isInAlloca() bool IndirectByVal : 1; // isIndirect() rjmccall wrote: > rnk wrote: > > rnk wrot

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

AntonYudintsev added inline comments. Comment at: clang/test/CodeGen/x86_32-arguments-win32.c:77 +// CHECK-LABEL: define dso_local void @receive_vec_256(<8 x float> inreg %x, <8 x float> inreg %y, <8 x float> inreg %z, <8 x float>* %0, <8 x float>* %1) +// CHECK-LABEL: define ds

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rjmccall added inline comments. Comment at: clang/test/CodeGen/x86_32-arguments-win32.c:77 +// CHECK-LABEL: define dso_local void @receive_vec_256(<8 x float> inreg %x, <8 x float> inreg %y, <8 x float> inreg %z, <8 x float>* %0, <8 x float>* %1) +// CHECK-LABEL: define dso_loca

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

AntonYudintsev added inline comments. Comment at: clang/test/CodeGen/x86_32-arguments-win32.c:77 +// CHECK-LABEL: define dso_local void @receive_vec_256(<8 x float> inreg %x, <8 x float> inreg %y, <8 x float> inreg %z, <8 x float>* %0, <8 x float>* %1) +// CHECK-LABEL: define ds

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rjmccall added inline comments. Comment at: clang/test/CodeGen/x86_32-arguments-win32.c:77 +// CHECK-LABEL: define dso_local void @receive_vec_256(<8 x float> inreg %x, <8 x float> inreg %y, <8 x float> inreg %z, <8 x float>* %0, <8 x float>* %1) +// CHECK-LABEL: define dso_loca

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

AntonYudintsev added inline comments. Comment at: clang/test/CodeGen/x86_32-arguments-win32.c:77 +// CHECK-LABEL: define dso_local void @receive_vec_256(<8 x float> inreg %x, <8 x float> inreg %y, <8 x float> inreg %z, <8 x float>* %0, <8 x float>* %1) +// CHECK-LABEL: define ds

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rjmccall added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:91 bool InAllocaSRet : 1;// isInAlloca() + bool InAllocaIndirect : 1;// isInAlloca() bool IndirectByVal : 1; // isIndirect() rnk wrote: > rnk wrote: > > rjmccall

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rnk marked an inline comment as done. rnk added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:91 bool InAllocaSRet : 1;// isInAlloca() + bool InAllocaIndirect : 1;// isInAlloca() bool IndirectByVal : 1; // isIndirect() rnk

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rnk marked 2 inline comments as done. rnk added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:91 bool InAllocaSRet : 1;// isInAlloca() + bool InAllocaIndirect : 1;// isInAlloca() bool IndirectByVal : 1; // isIndirect() rjm

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rjmccall added inline comments. Comment at: clang/test/CodeGen/x86_32-arguments-win32.c:77 +// CHECK-LABEL: define dso_local void @receive_vec_256(<8 x float> inreg %x, <8 x float> inreg %y, <8 x float> inreg %z, <8 x float>* %0, <8 x float>* %1) +// CHECK-LABEL: define dso_loca

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rnk marked 2 inline comments as done. rnk added inline comments. Comment at: clang/test/CodeGen/x86_32-arguments-win32.c:77 +// CHECK-LABEL: define dso_local void @receive_vec_256(<8 x float> inreg %x, <8 x float> inreg %y, <8 x float> inreg %z, <8 x float>* %0, <8 x float>* %1)

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rjmccall added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:91 bool InAllocaSRet : 1;// isInAlloca() + bool InAllocaIndirect : 1;// isInAlloca() bool IndirectByVal : 1; // isIndirect() Would it be better to handle `inallo

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

craig.topper added inline comments. Comment at: clang/test/CodeGen/x86_32-arguments-win32.c:77 +// CHECK-LABEL: define dso_local void @receive_vec_256(<8 x float> inreg %x, <8 x float> inreg %y, <8 x float> inreg %z, <8 x float>* %0, <8 x float>* %1) +// CHECK-LABEL: define dso_

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

erichkeane added a comment. I think this is alright, I want @ctopper to take a look before I approve it though. Additionally, do you know if this modifies the regcall calling convention at all? Should it? Comment at: clang/test/CodeGenCXX/inalloca-vector.cpp:71 +// CHECK-LA

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rnk created this revision. rnk added reviewers: rjmccall, craig.topper, erichkeane. Herald added a project: clang. MSVC 2013 would refuse to pass highly aligned things (typically vectors and aggregates) by value. Users would receive this error: t.cpp(11) : error C2719: 'w': formal parameter wit