amccarth added a comment.
It would surprise me if the different test config is cause here. The path is
assembled entirely in the code, so it should be consistent. If you had a
systemic problem introduced by test config, I'd expect more of the VFS tests to
fail.
Anyway, if you're back in busi
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0c7ca82161b5: Fix external-names.c test when separator is \\
(authored by michaelplatings).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71991/new/
https:/
michaelplatings added a comment.
Thanks for accepting.
The repo is up to date. I guess the reason the failure hasn't happened with the
build bots is that our downstream test setup differs somewhat from the norm -
our test runner imports lit.discovery & lit.LitConfig directly rather than
using t
amccarth added a comment.
I'm still not seeing how the backslashes got in there for you. They don't
happen for me. It looks like these paths come (almost) directly from the temp
.yaml files created by the `sed` commands at the beginning of the test, so--for
these particular tests--I'd expect
amccarth accepted this revision.
amccarth added a comment.
I've made a similar change in several other tests, but this test works for me
without this change. I'm trying to understand why, but I don't see any harm in
landing this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTIO
rnk accepted this revision.
rnk added a comment.
lgtm, but why doesn't this show up on existing clang windows bots? For example:
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/13276
IIRC clang often joins paths with `/`, so maybe this separator is always `/`
upstream. Do you hav
miyuki accepted this revision.
miyuki added a comment.
This revision is now accepted and ready to land.
LGTM. Let's wait for someone else to approve (or commit after holidays if no
one objects).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71991/n
michaelplatings created this revision.
michaelplatings added reviewers: rnk, amccarth, dsanders, miyuki.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
michaelplatings edited the summary of this revision.
This fixes the following failure:
C:\[...]\llvm\tools\clang\test\V
