[PATCH] D71969: [OpenMP] diagnose zero-length array section in the depend clause

This revision was automatically updated to reflect the committed changes. Closed by commit rG427ffa2cdbbc: [OpenMP] diagnose zero-length array section in the depend clause (authored by kkwli0). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D71969: [OpenMP] diagnose zero-length array section in the depend clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71969/new/ https://reviews.llvm.org/D71969 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D71969: [OpenMP] diagnose zero-length array section in the depend clause

kkwli0 updated this revision to Diff 235894. kkwli0 added a comment. Update based on suggestion to simply the check and rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71969/new/ https://reviews.llvm.org/D71969 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib

[PATCH] D71969: [OpenMP] diagnose zero-length array section in the depend clause

kkwli0 added a comment. In D71969#1798224 , @jdoerfert wrote: > Is there a reason not to put this check right next to the one that issues > `err_omp_section_length_negative`. SemaExpr.cpp +4668 It is a good idea to group the checking together however th

[PATCH] D71969: [OpenMP] diagnose zero-length array section in the depend clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15031-15033 +Length->EvaluateAsInt(Result, Context)) { + llvm::APSInt ConstLength = Result.Val.getInt(); + if (ConstLength.getSExtValue() == 0) { Just `.. Lengt

[PATCH] D71969: [OpenMP] diagnose zero-length array section in the depend clause

jdoerfert added a comment. I would put this check right next to the one that issues `err_omp_section_length_negative`. SemaExpr.cpp +4668 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71969/new/ https://reviews.llvm.org/D71969 ___ cfe-comm

[PATCH] D71969: [OpenMP] diagnose zero-length array section in the depend clause

kkwli0 created this revision. kkwli0 added a reviewer: ABataev. Herald added a subscriber: guansong. Herald added a reviewer: jdoerfert. The OpenMP specification disallows having zero-length array sections in the depend clause (OpenMP 5.0 2.17.11). https://reviews.llvm.org/D71969 Files: clan