[PATCH] D71686: Fix false positive in magic number checker

aaron.ballman closed this revision. aaron.ballman added a comment. In D71686#1794377 , @0x8000- wrote: > @aaron.ballman updated as suggested; please commit/integrate when you have a > moment. Thank you! Happy to do so, thank you for the fix! I've co

[PATCH] D71686: Fix false positive in magic number checker

0x8000- added a comment. @aaron.ballman updated as suggested; please commit/integrate when you have a moment. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71686/new/ https://reviews.llvm.org/D71686 ___ cfe-commits mailing l

[PATCH] D71686: Fix false positive in magic number checker

0x8000- marked 2 inline comments as done. 0x8000- added a comment. In D71686#1794366 , @aaron.ballman wrote: > In D71686#1794360 , @0x8000- > wrote: > > > In D71686#1794330

[PATCH] D71686: Fix false positive in magic number checker

0x8000- updated this revision to Diff 235060. 0x8000- added a comment. Minor comment fixes; capitalization, full stop. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71686/new/ https://reviews.llvm.org/D71686 Files: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cp

[PATCH] D71686: Fix false positive in magic number checker

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-magic-numbers-todo.cpp:2 +// RUN: %check_clang_tidy %s read

[PATCH] D71686: Fix false positive in magic number checker

aaron.ballman added a comment. In D71686#1794360 , @0x8000- wrote: > In D71686#1794330 , @aaron.ballman > wrote: > > > In D71686#1794053 , @0x8000- > > wrote: > > >

[PATCH] D71686: Fix false positive in magic number checker

0x8000- added a comment. In D71686#1794330 , @aaron.ballman wrote: > In D71686#1794053 , @0x8000- > wrote: > > > My take: this change fixes a user-reported bug, and does not cause any > > known regression

[PATCH] D71686: Fix false positive in magic number checker

aaron.ballman added a comment. In D71686#1794053 , @0x8000- wrote: > My take: this change fixes a user-reported bug, and does not cause any known > regressions. I think we should integrate this. I sort of wonder whether we want to document this as a

[PATCH] D71686: Fix false positive in magic number checker

0x8000- added a comment. My take: this change fixes a user-reported bug, and does not cause any known regressions. I think we should integrate this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71686/new/ https://reviews.llvm.org/D71686 _

[PATCH] D71686: Fix false positive in magic number checker

0x8000- marked an inline comment as done. 0x8000- added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-magic-numbers-todo.cpp:9 +{ + if (((int)4) > ProcessSomething(10)) + // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: 4 is a magic nu

[PATCH] D71686: Fix false positive in magic number checker

0x8000- updated this revision to Diff 234998. 0x8000- added a comment. Add a test file for expected failures CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71686/new/ https://reviews.llvm.org/D71686 Files: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp clang-

[PATCH] D71686: Fix false positive in magic number checker

0x8000- marked an inline comment as done. 0x8000- added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp:129 +// expanded class enumeration value. +if (Parent.get()) +

[PATCH] D71686: Fix false positive in magic number checker

0x8000- marked an inline comment as done. 0x8000- added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp:129 +// expanded class enumeration value. +if (Parent.get()) +

[PATCH] D71686: Fix false positive in magic number checker

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp:129 +// expanded class enumeration value. +if (Parent.get()) + return true; So

[PATCH] D71686: Fix false positive in magic number checker

0x8000- updated this revision to Diff 234819. 0x8000- added a comment. Fix typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71686/new/ https://reviews.llvm.org/D71686 Files: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp clang-tools-extra/docs/ReleaseNote

[PATCH] D71686: Fix false positive in magic number checker

0x8000- updated this revision to Diff 234818. 0x8000- edited the summary of this revision. 0x8000- added a comment. Update release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71686/new/ https://reviews.llvm.org/D71686 Files: clang-tools-extra/clang-tidy/readabili

[PATCH] D71686: Fix false positive in magic number checker

Eugene.Zelenko added a comment. Please mention fix in Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71686/new/ https://reviews.llvm.org/D71686 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D71686: Fix false positive in magic number checker

0x8000- marked an inline comment as done. 0x8000- added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp:127 + +// Ignore this instance, because this matches an +// expanded class e

[PATCH] D71686: Fix false positive in magic number checker

0x8000- created this revision. 0x8000- added a reviewer: aaron.ballman. 0x8000- added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix false positive in magic number checker https://bugs.llvm.org/show_bug.cgi?id=40640: cppcoregu