[PATCH] D71652: [clangd] Replace shortenNamespace with getQualification

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rGb2eaac3e3e0a: [clangd] Replace shortenNamespace with getQualification (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D71652?vs=23456

[PATCH] D71652: [clangd] Replace shortenNamespace with getQualification

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/AST.cpp:307 + llvm::raw_string_ostream OS(Result); + auto Decls = explicitReferenceTargets( + ast_type_traits::

[PATCH] D71652: [clangd] Replace shortenNamespace with getQualification

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71652/new/ https://reviews.llvm.org/D71652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D71652: [clangd] Replace shortenNamespace with getQualification

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D71652: [clangd] Replace shortenNamespace with getQualification

kadircet updated this revision to Diff 234564. kadircet added a comment. - Use explicitTargetReferences - Added some testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71652/new/ https://reviews.llvm.org/D71652 Files: clang-tools-extra/clangd

[PATCH] D71652: [clangd] Replace shortenNamespace with getQualification

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:305 + llvm::raw_string_ostream OS(Result); + if (auto *TD = QT->getAsTagDecl()) +OS << getQualification(CurContext.getParentASTContext(), &CurContext, TD, Why not use `explici

[PATCH] D71652: [clangd] Replace shortenNamespace with getQualification

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60978 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71652: [clangd] Replace shortenNamespace with getQualification

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71652 Files: clang-tools-extra/clangd/AST.cpp