This revision was automatically updated to reflect the committed changes.
Closed by commit rG810b28edb3f6: [ItaniumCXXABI] Make tls wrappers properly
comdat (authored by mstorsjo).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71572/new/
https://rev
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
This will be a small change in behavior, but nobody on ELF should notice
because things with vague linkage there are both ELF-weak and comdat.
Comment at: clang/lib/CodeGen/
mstorsjo added a comment.
@rnk and/or @rsmith - can either of you have a look at the new version of this?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71572/new/
https://reviews.llvm.org/D71572
___
cfe-commits mailing list
cfe-commits@list
mstorsjo added a comment.
@rsmith - does this look right to you?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71572/new/
https://reviews.llvm.org/D71572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
mstorsjo updated this revision to Diff 236664.
mstorsjo retitled this revision from "[ItaniumCXXABI] Make tls wrappers comdat
on Windows" to "[ItaniumCXXABI] Make tls wrappers properly comdat".
mstorsjo edited the summary of this revision.
mstorsjo added a comment.
Making the tls wrappers comdat
