[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

rupprecht added a comment. In D71554#1789360 , @arichardson wrote: > Also handle -h/-v as short options. Does the adjusted test look okay? Sorry, didn't have time to take a second look before the holiday break -- yep, looks good, I didn't anticipate so

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

thakis added a comment. In D71554#1801246 , @arichardson wrote: > Should be fixed in > https://github.com/llvm/llvm-project/commit/a4f3847f3d5742cfab7acdc614e7ca54643e0c85 Thanks! Now it fails with a different error: http://45.33.8.238/win/4962/step_11

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson added a comment. Should be fixed in https://github.com/llvm/llvm-project/commit/a4f3847f3d5742cfab7acdc614e7ca54643e0c85 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71554/new/ https://reviews.llvm.org/D71554 __

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson added a comment. In D71554#1801203 , @thakis wrote: > The test fails on Windows: http://45.33.8.238/win/4948/step_11.txt > > Please take a look, and if takes a while to fix, revert in the meantime. I'll just relax the permissions check. We on

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

thakis added a comment. The test fails on Windows: http://45.33.8.238/win/4948/step_11.txt Please take a look, and if takes a while to fix, revert in the meantime. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71554/new/ https://reviews.llvm.org/D

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG535b3c6b2f1c: [llvm-ranlib] Handle -D and -U command line flag (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71554/new/ https://r

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson updated this revision to Diff 234506. arichardson added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71554/new/ https://reviews.llvm.org/D71554 Files: llvm/test/tools/llvm-ranlib/D-flag.test llvm/test/tools

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60990 tests passed, 1 failed and 728 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_timedmutex_requirements/thread_timedmutex_class/lock.pass.cpp {icon times-circle color=

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson updated this revision to Diff 234479. arichardson added a comment. Also handle -h/-v as short options. Does the adjusted test look okay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71554/new/ https://reviews.llvm.org/D71554 Files:

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

rupprecht accepted this revision. rupprecht added a comment. This revision is now accepted and ready to land. Looks good for D/U, but looks like --help and --version options are also supported as combined short args; do you mind adding those too while you're here? Thanks for the patch! =

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson marked an inline comment as done. arichardson added inline comments. Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:69 + --version - Display the version of this program + -D- Use zero for timestamps and uids/gids (default) + -U

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

emaste added inline comments. Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:69 + --version - Display the version of this program + -D- Use zero for timestamps and uids/gids (default) + -U- Use actual timestamps and uids/gids ---

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60963 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson updated this revision to Diff 234088. arichardson added a comment. Force UTC timezone for reproducible results Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71554/new/ https://reviews.llvm.org/D71554 Files: llvm/test/tools/llvm-ranli

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60962 tests passed, 1 failed and 726 were skipped. failed: LLVM.tools/llvm-ranlib/D-flag.test {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60962 tests passed, 1 failed and 726 were skipped. failed: LLVM.tools/llvm-ranlib/D-flag.test {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson updated this revision to Diff 234082. arichardson added a comment. Drop unrelated change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71554/new/ https://reviews.llvm.org/D71554 Files: llvm/test/tools/llvm-ranlib/D-flag.test llvm/t

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson created this revision. arichardson added a reviewer: rupprecht. Herald added subscribers: llvm-commits, cfe-commits, krytarowski, emaste. Herald added projects: clang, LLVM. arichardson updated this revision to Diff 234082. arichardson added a comment. Drop unrelated change I have be