[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG61ff29637501: [RISCV] Add Clang frontend support for Bitmanip extension (authored by s.egerton, committed by simoncook). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

s.egerton accepted this revision. s.egerton added a comment. Looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.llvm.org/D71553 ___ cfe-commits mailing list cfe-c

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

simoncook updated this revision to Diff 250871. simoncook added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.llvm.org/D71553 Files: clang/lib/Basic/Targets/RISCV.cpp clang/lib/Basic/Targe

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:129 + + if (HasB) { +Builder.defineMacro("__riscv_bitmanip"); delete `{}` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

simoncook updated this revision to Diff 250771. simoncook added a comment. Herald added a subscriber: evandro. Rebase on new dependencies Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.llvm.org/D71553 Files: clang/lib/B

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

simoncook updated this revision to Diff 242082. simoncook added a comment. Rebase changes on top of experimental feature support (D73891 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.ll

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

lenary reopened this revision. lenary added a comment. This revision is now accepted and ready to land. @s.egerton Thank you. Sorry again for the confusion. Reverted in rGcbe681bd8339d3a018d25441a5f4ef9da2bd017d Repository:

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

s.egerton added a comment. Good point. It's reverted now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.llvm.org/D71553 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

lenary added a comment. @s.egerton Please can you revert rG57cf6ee9c84434161088c39a6f8dd2aae14eb12d - this patch has open dependencies, including on the LLVM support for RISC-V B extension. It would be confusing to users if c

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG57cf6ee9c844: [RISCV] Add Clang frontend support for Bitmanip extension (authored by s.egerton). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ ht

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.llvm.org/D71553 __

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

s.egerton updated this revision to Diff 234308. s.egerton added a comment. Add test that march 'b' flag enables __riscv_bitmanip. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.llvm.org/D71553 Files: clang/lib/Basic/Tar

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

lewis-revill added a comment. Thanks Scott, it should be relatively easy to add tests for this in 'clang/test/Preprocessor/riscv-target-features.c' if you could. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.llvm.org/D71

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

s.egerton created this revision. s.egerton added reviewers: asb, simoncook, lewis-revill, PaoloS, lenary. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, Ma