This revision was automatically updated to reflect the committed changes.
Closed by commit rG0a1e349a7933: [WebAssembly] Setting export_name implies
llvm.used (authored by sbc100).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71493/new/
https://rev
sbc100 updated this revision to Diff 234160.
sbc100 added a comment.
- revert part
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71493/new/
https://reviews.llvm.org/D71493
Files:
clang/lib/Sema/SemaDeclAttr.cpp
clang/test/CodeGen/wasm-export-n
sbc100 marked an inline comment as done.
sbc100 added inline comments.
Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:725
TOut.emitExportName(WasmSym, ExportName);
+ Out.EmitSymbolAttribute(WasmSym, MCSA_NoDeadStrip);
}
---
sunfish added inline comments.
Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:725
TOut.emitExportName(WasmSym, ExportName);
+ Out.EmitSymbolAttribute(WasmSym, MCSA_NoDeadStrip);
}
It feels like this is a little inconsi
sbc100 updated this revision to Diff 234144.
sbc100 added a comment.
rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71493/new/
https://reviews.llvm.org/D71493
Files:
clang/lib/Sema/SemaDeclAttr.cpp
clang/test/CodeGen/wasm-export-name.c
sbc100 created this revision.
Herald added subscribers: llvm-commits, cfe-commits, sunfish, aheejin,
hiraditya, jgravelle-google, dschuff.
Herald added projects: clang, LLVM.
sbc100 added reviewers: dschuff, sunfish.
This change updates the clang front end to add symbols to llvm.used
when they ha
