This revision was automatically updated to reflect the committed changes.
Closed by commit rG308b8b76ceee: [OpenCL] Add builtin function extension
handling (authored by svenvh).
Herald added a project: clang.
Changed prior to commit:
https://reviews.llvm.org/D71476?vs=233826&id=234491#toc
Repo
svenvh marked 2 inline comments as done.
svenvh added inline comments.
Comment at: clang/lib/Sema/OpenCLBuiltins.td:51
+// Extension associated to a builtin function.
+class FunctionExtension : AbstractExtension<_Ext>;
+
Anastasia wrote:
> Are we planning to add
Nicola accepted this revision.
Nicola added a comment.
Just a minor comment, can you address it before you submit? Thanks!
Comment at: clang/lib/Sema/OpenCLBuiltins.td:1095
// OpenCL v2.0 s9.17.3: Additions to section 6.13.1: Work-Item Functions
+def FuncExtKhrSubgroups : Func
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
Comment at: clang/lib/Sema/OpenCLBuiltins.td:51
+// Extension associated to a builtin function.
+class FunctionExtension : AbstractExtension<_Ext>;
+
svenvh created this revision.
svenvh added reviewers: Anastasia, Nicola.
Herald added subscribers: jfb, yaxunl.
Herald added a reviewer: rengolin.
Provide a mechanism to attach OpenCL extension information to builtin
functions, so that their use can be restricted according to the
extension(s) the
