[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin added a comment. Is there any chance to get this commit cherry-picked to 10.x branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71460/new/ https://reviews.llvm.org/D71460 ___ cfe-commi

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

svenvh added a comment. I have updated the TableGen OpenCL builtin definitions accordingly in 91b3083aecd ("[OpenCL] Fix tblgen support for cl_khr_mipmap_image_writes", 2020-02-05). Repository: rG LLVM Github Monorepo CH

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

This revision was automatically updated to reflect the committed changes. AlexeySotkin marked an inline comment as done. Closed by commit rGf780e15caf1b: [OpenCL] Fix support for cl_khr_mipmap_image_writes (authored by AlexeySotkin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

svenvh added a comment. In D71460#1844959 , @Anastasia wrote: > Adding @svenvh mainly to check if any fix is needed for the TableGen BIFs too? Yes I believe we should also update `clang/lib/Sema/OpenCLBuiltins.td`. CHANGES SINCE LAST ACTION https://r

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

Anastasia added a comment. Adding @svenvh mainly to check if any fix is needed for the TableGen BIFs too? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71460/new/ https://reviews.llvm.org/D71460 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Comment at: clang/lib/Headers/opencl-c.h:14686 +#if defined(cl_khr_mipmap_image_writes) +#pragma OPENCL EXTENSION cl_khr_mipmap_image_writes : begin void

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin marked 2 inline comments as done. AlexeySotkin added inline comments. Comment at: clang/lib/Headers/opencl-c.h:14686 +#if defined(cl_khr_mipmap_image_writes) +#pragma OPENCL EXTENSION cl_khr_mipmap_image_writes : begin void __ovld write_imagef(write_only image1d_t i

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin updated this revision to Diff 240510. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71460/new/ https://reviews.llvm.org/D71460 Files: clang/include/clang/Basic/OpenCLExtensions.def clang/lib/Headers/opencl-c.h clang/test/SemaOpenCL/extension-version.cl Index: clang/t

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c.h:14686 +#if defined(cl_khr_mipmap_image_writes) +#pragma OPENCL EXTENSION cl_khr_mipmap_image_writes : begin void __ovld write_imagef(write_only image1d_t image, int coord, int lod, float4 color);

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin updated this revision to Diff 234674. AlexeySotkin added a comment. Rename `color` to `depth` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71460/new/ https://reviews.llvm.org/D71460 Files: clang/include/clang/Basic/OpenCLExtensions.def clang/lib/Headers/opencl-c.h c

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin marked an inline comment as done. AlexeySotkin added inline comments. Comment at: clang/lib/Headers/opencl-c.h:14686 +#if defined(cl_khr_mipmap_image_writes) +#pragma OPENCL EXTENSION cl_khr_mipmap_image_writes : begin void __ovld write_imagef(write_only image1d_t i

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin added a comment. In D71460#1783390 , @asavonic wrote: > What about `get_image_num_mip_levels` functions defined in the extension > specification? > > Edit: I mean, should the `get_image_num_mip_levels(write_only img)` function > be only avai

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c.h:14686 +#if defined(cl_khr_mipmap_image_writes) +#pragma OPENCL EXTENSION cl_khr_mipmap_image_writes : begin void __ovld write_imagef(write_only image1d_t image, int coord, int lod, float4 color);

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

asavonic added a comment. What about `get_image_num_mip_levels` functions defined in the extension specification? Comment at: clang/lib/Headers/opencl-c.h:14780 void __ovld write_imagef(read_write image2d_depth_t image, int2 coord, int lod, float color); void __ovld write

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin created this revision. AlexeySotkin added reviewers: Anastasia, svenvh, yaxunl, asavonic. Herald added a project: clang. Herald added a subscriber: cfe-commits. Patch by Ilya Mashkov Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71460 Files: clang/include/clang