Re: [PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

2019-12-12 Thread Eric Christopher via cfe-commits
No worries, it happens. On Thu, Dec 12, 2019, 10:59 PM Michał Górny wrote: > On Thu, 2019-12-12 at 14:47 -0800, Eric Christopher wrote: > > As a quick note, this broke the test because you didn't update the line > > numbers in the checks. > > > > Fixed thusly: > > > > echristo@athyra ~/r/llvm-pr

Re: [PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

2019-12-12 Thread Michał Górny via cfe-commits
On Thu, 2019-12-12 at 14:47 -0800, Eric Christopher wrote: > As a quick note, this broke the test because you didn't update the line > numbers in the checks. > > Fixed thusly: > > echristo@athyra ~/r/llvm-project> git push > To github.com:llvm/llvm-project.git >6bed43f3c40..259a9b10390 maste

[PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

2019-12-12 Thread Michał Górny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4c6c1d0f4371: [clang] [test] Disable the test exhausting stack on NetBSD (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

Re: [PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

2019-12-12 Thread Eric Christopher via cfe-commits
As a quick note, this broke the test because you didn't update the line numbers in the checks. Fixed thusly: echristo@athyra ~/r/llvm-project> git push To github.com:llvm/llvm-project.git 6bed43f3c40..259a9b10390 master -> master :) -eric On Thu, Dec 12, 2019 at 12:25 PM Petr Hosek via Pha

[PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

2019-12-12 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71419/new/ https://reviews.llvm.org/D71419 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

2019-12-12 Thread Michał Górny via Phabricator via cfe-commits
mgorny created this revision. mgorny added reviewers: krytarowski, rsmith, compnerd, phosek. Disable the instantiation-depth-default.cpp test on NetBSD since it requires more stack space than we have by default on NetBSD. https://reviews.llvm.org/D71419 Files: clang/test/SemaTemplate/instanti