[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

This revision was automatically updated to reflect the committed changes. Closed by commit rG583ba07884ed: [clangd] Add xref for macros to FileIndex. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71406/new/ https://reviews.l

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61298 tests passed, 0 failed and 736 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

usaxena95 updated this revision to Diff 236618. usaxena95 added a comment. Added tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71406/new/ https://reviews.llvm.org/D71406 Files: clang-tools-extra/clangd/index/FileIndex.cpp clang-tools-ex

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60496 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

usaxena95 updated this revision to Diff 236569. usaxena95 marked an inline comment as done. usaxena95 added a comment. Removed extra tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71406/new/ https://reviews.llvm.org/D71406 Files: clang-too

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60496 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

ilya-biryukov accepted this revision. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:362 + R.Location.End.setColumn(Range.en

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

usaxena95 marked 2 inline comments as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:362 + R.Location.End.setColumn(Range.end.character); + R.Location.FileURI = MainFileURI.c_str(); + // FIXME: Add correct RefK

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

usaxena95 updated this revision to Diff 236541. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71406/new/ https://reviews.llvm.org/D71406 Files: clang-tool

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:350 + const auto *MainFileEntry = SM.getFileEntryForID(SM.getMainFileID()); + if (!MainFileEntry) +return; Does this ever happen? Maybe `assert` it's not nul

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60496 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

usaxena95 updated this revision to Diff 236037. usaxena95 marked 5 inline comments as done. usaxena95 added a comment. Added another version of `handleMacroOccurence` to handle MacroReferences from main file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:86 +// Add macro references. +for (const auto &IDToRefs : MacroRefsToIndex->MacroRefs) { + for (const auto &Range : IDToRefs.second) { ilya-biryukov wrote: > ho

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:86 +// Add macro references. +for (const auto &IDToRefs : MacroRefsToIndex->MacroRefs) { + for (const auto &Range : IDToRefs.second) { hokein wrote: > ilya-

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

hokein added a comment. @ilya-biryukov thanks for taking it during my OOO, just a drive-by comment :) Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:86 +// Add macro references. +for (const auto &IDToRefs : MacroRefsToIndex->MacroRefs) { + for (const auto

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/URI.h:115 +// the SourceManager. +URI toURI(llvm::StringRef Path, const SourceManager &SM, + const std::string &FallbackDir); This function does a very specialized form of path-to-

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60496 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Adds macro references to the dynamic index. Tests added. Also exposed a new API to convert path to URI i