[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

This revision was automatically updated to reflect the committed changes. Closed by commit rGec618826dfb9: [clangd] Rename constructors and destructors in cross-file case (authored by kbobyrev). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

kbobyrev updated this revision to Diff 233571. kbobyrev marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71247/new/ https://reviews.llvm.org/D71247 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/unittests/RenameTests.cpp I

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:92 + DeclRelation::Alias | DeclRelation::TemplatePattern)) { +const auto *ND = llvm::cast(D); +// Get to CXXRecordDecl from constructor or destructor. --

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG but the cast needs to be fixed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71247/new/ https://reviews.llvm.org/D71247 ___ cfe

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

kbobyrev updated this revision to Diff 233563. kbobyrev marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71247/new/ https://reviews.llvm.org/D71247 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/unittests/RenameTests.cpp I

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:91 + DeclRelation::Alias | DeclRelation::TemplatePattern)) { +// If the cursor is at the underlying CXXRecordDecl of the +// ClassTemplateDecl, ND will be the CXXRec

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

kbobyrev updated this revision to Diff 233533. kbobyrev marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71247/new/ https://reviews.llvm.org/D71247 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/unittests/RenameTests.cpp I

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:91 + DeclRelation::Alias | DeclRelation::TemplatePattern)) { +// If the cursor is at the underlying CXXRecordDecl of the +// ClassTemplateDecl, ND will be the CXXReco

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:91 + DeclRelation::Alias | DeclRelation::TemplatePattern)) { +// If the cursor is at the underlying CXXRecordDecl of the +// ClassTemplateDecl, ND will be the CXXRec

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

kbobyrev updated this revision to Diff 233381. kbobyrev marked an inline comment as done. kbobyrev added a comment. Address the comments and simplify the code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71247/new/ https://reviews.llvm.org/D71247 Files: clang-tools-extra/clangd/ref

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to address the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71247/new/ https://reviews.llvm.org/D71247 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:91 if (const auto *D = SelectedNode->ASTNode.get()) { -if (D->getLocation() != TokenStartLoc) - return {}; +if (D->getLocation() != TokenStartLoc) { + // Destructor->get

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

kbobyrev updated this revision to Diff 233048. kbobyrev marked an inline comment as done. kbobyrev added a comment. Add another test for `~^Foo` and rebase on top of master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71247/new/ https://reviews.llvm.org/D71247 Files: clang-tools-ex

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:699 + [[Foo]](); + ^~[[Foo]](); +}; could you also add a case with `~^Foo()` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71247/new

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

kbobyrev updated this revision to Diff 233037. kbobyrev added a comment. Improve wording in the comment I moved. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71247/new/ https://reviews.llvm.org/D71247 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/uni