[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge added a comment. In D71240#1782828 , @nridge wrote: > In D71240#1782763 , @thakis wrote: > > > Probably needs the usual -fno-delayed-template-parsing workaround, see > > other clangd tests. > > > Thanks for

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge added a comment. In D71240#1782763 , @thakis wrote: > Probably needs the usual -fno-delayed-template-parsing workaround, see other > clangd tests. Thanks for the suggestion! Fix at https://reviews.llvm.org/D71444 Repository: rG LLVM Github Mo

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

thakis added a comment. Tests fail on Windows: http://45.33.8.238/win/3976/step_9.txt Probably needs the usual -fno-delayed-template-parsing workaround, see other clangd tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71240/new/ https://revi

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

This revision was automatically updated to reflect the committed changes. Closed by commit rGecaa9363303e: [clangd] Heuristically resolve dependent method calls (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D71240?vs=233681&id=233698#toc Repository: rG LLVM Github M

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:278 +}); +for (const NamedDecl *D : Decls) { + Outer.add(D, Flags); sammccall wrote: > sammccall wrote: > > can we make this function return the decls,

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge updated this revision to Diff 233681. nridge marked an inline comment as done. nridge added a comment. Fix a typo and address one remaining comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71240/new/ https://reviews.llvm.org/D71240 Fil

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge updated this revision to Diff 233680. nridge marked 7 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71240/new/ https://reviews.llvm.org/D71240 Files: clang-tools-ext

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge added a comment. `unique_ptr` is harder to get to work than it might appear at first blush :) Looking at the gcc 6 libstdc++ implementation as an example: the declared return type is not `T*`, but `unique_ptr::pointer`. The declaration of that is in turn: typedef typename _Pointer::ty

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Awesome, thanks, I'd been hoping to get around to this! LG with some naming/structure nits. This doesn't handle references into smart pointers (details below), but feel free to do that i

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge updated this revision to Diff 232998. nridge added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71240/new/ https://reviews.llvm.org/D71240 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/XRef

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. nridge updated this revision to Diff 232996. nridge added a comment. nridge edited the summary of

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge updated this revision to Diff 232996. nridge added a comment. Add github issue number Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71240/new/ https://reviews.llvm.org/D71240 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-ex