[PATCH] D71226: Also synthesize _cmd and self for properties

liuliu added a comment. Thanks. Verified in our codebase this patch indeed fixed the crashes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71226/new/ https://reviews.llvm.org/D71226 ___ cfe-commits ma

[PATCH] D71226: Also synthesize _cmd and self for properties

This revision was automatically updated to reflect the committed changes. Closed by commit rG1646bb866433: Also synthesize _cmd and self for properties (authored by MadCoder, committed by arphaman). Changed prior to commit: https://reviews.llvm.org/D71226?vs=232928&id=232944#toc Repository:

[PATCH] D71226: Also synthesize _cmd and self for properties

rjmccall added a comment. Alternatively, we could make IRGen not depend on those parameters being set just to call a function, which seems reasonable since the parameter variables are logically internal to the implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D71226: Also synthesize _cmd and self for properties

MadCoder added a comment. In D71226#1776038 , @rjmccall wrote: > It'd be nice if we didn't have to synthesize parameters for all declarations > when we're just handling an `@interface`, but we can improve that in > follow-ups. yeah ideally I'd want to

[PATCH] D71226: Also synthesize _cmd and self for properties

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71226/new/ https://reviews.llvm.org/D71226 ___

[PATCH] D71226: Also synthesize _cmd and self for properties

rjmccall added a comment. It'd be nice if we didn't have to synthesize parameters for all declarations when we're just handling an `@interface`, but we can improve that in follow-ups. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71226/new/ https:

[PATCH] D71226: Also synthesize _cmd and self for properties

MadCoder added a comment. @liuliu that fixes your test case (which I reproduced in the CG test) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71226/new/ https://reviews.llvm.org/D71226 ___ cfe-commits

[PATCH] D71226: Also synthesize _cmd and self for properties

MadCoder created this revision. MadCoder added reviewers: liuliu, rjmccall, arphaman, jfb. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. MadCoder added a comment. @liuliu that fixes your test case (which I reproduced in the CG test) Radar-Id: rdar://problem/57