This revision was automatically updated to reflect the committed changes.
Closed by commit rG0508c994f0b1: [clang] Turn -fno-builtin flag into an IR
Attribute (authored by gchatelet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71193/new/
https://
gchatelet marked an inline comment as done.
gchatelet added inline comments.
Comment at: clang/test/CodeGen/libcalls-fno-builtin.c:163
-// CHECK: [[ATTR]] = { nobuiltin }
+// GLOBAL: #2 = { nobuiltin "no-builtins" }
+// INDIVIDUAL: #2 = { nobuiltin "no-builtin-ceil" "no-builtin
tejohnson added inline comments.
Comment at: clang/test/CodeGen/libcalls-fno-builtin.c:163
-// CHECK: [[ATTR]] = { nobuiltin }
+// GLOBAL: #2 = { nobuiltin "no-builtins" }
+// INDIVIDUAL: #2 = { nobuiltin "no-builtin-ceil" "no-builtin-copysign"
"no-builtin-cos" "no-builtin-fab
gchatelet marked an inline comment as done.
gchatelet added inline comments.
Comment at: clang/test/CodeGen/libcalls-fno-builtin.c:163
-// CHECK: [[ATTR]] = { nobuiltin }
+// GLOBAL: #2 = { nobuiltin "no-builtins" }
+// INDIVIDUAL: #2 = { nobuiltin "no-builtin-ceil" "no-builtin
tejohnson added a comment.
This LGTM, although I have a couple of questions that are orthogonal to this
patch and shouldn't block it. Please wait to see if @aaron.ballman has any more
comments.
Comment at: clang/test/CodeGen/libcalls-fno-builtin.c:163
-// CHECK: [[ATTR]] =
gchatelet updated this revision to Diff 233272.
gchatelet marked 3 inline comments as done.
gchatelet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71193/new/
https://reviews.llvm.org/D71193
Files:
clang/lib/C
aaron.ballman added reviewers: efriedma, tejohnson, hfinkel.
aaron.ballman added a comment.
Adding a few more reviewers who may know more about LLVM attributes.
Comment at: clang/lib/CodeGen/CGCall.cpp:1884
+else {
+ const auto AddNoBuiltinAttr = [&FuncAttrs](S
gchatelet created this revision.
gchatelet added reviewers: aaron.ballman, courbet.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This is a follow up on https://reviews.llvm.org/D61634#1742154 to turn the
clang driver -fno-builtin flag into an IR attribute.
I also investi
