[PATCH] D71166: Deprecate the hasDefaultArgument matcher

2019-12-10 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3e315ba2547c: Deprecate the hasDefaultArgument matcher (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D71166?vs=232711&id=233177#toc Repository: rG LLVM Github Monorepo

[PATCH] D71166: Deprecate the hasDefaultArgument matcher

2019-12-07 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a small doc request. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6555 +/// \endcode +/// parmVarDecl(hasInitializer(integerLiteral(equal

[PATCH] D71166: Deprecate the hasDefaultArgument matcher

2019-12-07 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. It doesn't provide a way to match on the contents of the default argumment. Rather than give it that capability, make it deprecated and recomment the us