[PATCH] D71159: [Attr] Move ParsedTargetAttr out of the TargetAttr class

This revision was automatically updated to reflect the committed changes. Closed by commit rG505aa2410db6: [Attr] Move ParsedTargetAttr out of the TargetAttr class (authored by craig.topper). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D71159: [Attr] Move ParsedTargetAttr out of the TargetAttr class

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71159/new/ https://reviews.llvm.org/D71159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D71159: [Attr] Move ParsedTargetAttr out of the TargetAttr class

rnk accepted this revision. rnk added a comment. Lg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71159/new/ https://reviews.llvm.org/D71159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D71159: [Attr] Move ParsedTargetAttr out of the TargetAttr class

craig.topper marked an inline comment as done. craig.topper added inline comments. Comment at: clang/include/clang/AST/Attr.h:359 } } // end namespace clang There's an ending namespace comment here and there's no namespace starting since the end of my chan

[PATCH] D71159: [Attr] Move ParsedTargetAttr out of the TargetAttr class

erichkeane added a comment. Should this be in a namespace? Can't tell from the header file, is it at least in clang? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71159/new/ https://reviews.llvm.org/D71159 ___ cfe-commits mailing list cfe-

[PATCH] D71159: [Attr] Move ParsedTargetAttr out of the TargetAttr class

craig.topper created this revision. craig.topper added reviewers: rnk, echristo, erichkeane. Need to forward declare it in ASTContext.h for D68627 , so it can't be a nested struct. https://reviews.llvm.org/D71159 Files: clang/include/clang/AST/Attr.h clang/