[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

2019-12-07 Thread Mark de Wever via Phabricator via cfe-commits
Mordante marked 3 inline comments as done. Mordante added inline comments. Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef AttributeSpelling = +CPlusPlus14 ? "[[deprecated]]" : "__attribute__((deprecated))"; if (PP) { Mordante wrote: > a

[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

2019-12-06 Thread Mark de Wever via Phabricator via cfe-commits
Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef AttributeSpelling = +CPlusPlus14 ? "[[deprecated]]" : "__attribute__((deprecated))"; if (PP) { aaron.ballman wrote

[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

2019-12-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef AttributeSpelling = +CPlusPlus14 ? "[[deprecated]]" : "__attribute__((deprecated))"; if (PP) { Mordante wrote: > aaron.ballman wrote: > > This attribute

[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

2019-12-06 Thread Mark de Wever via Phabricator via cfe-commits
Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef AttributeSpelling = +CPlusPlus14 ? "[[deprecated]]" : "__attribute__((deprecated))"; if (PP) { aaron.ballman wrote

[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

2019-12-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef AttributeSpelling = +CPlusPlus14 ? "[[deprecated]]" : "__attribute__((deprecated))"; if (PP) { This attribute also exists with this spelling in C2x, FWI

[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

2019-12-06 Thread Mark de Wever via Phabricator via cfe-commits
Mordante created this revision. Mordante added a reviewer: gribozavr2. Mordante added a project: clang. This replaces the non-standard `__attribute__((deprecated))` with the standard `[[deprecated]]` when compiling in C++14 mode. Discovered while looking at https://bugs.llvm.org/show_bug.cgi?id=