zatrazz added a comment.
Hi,
I am investigating a recurring regression on aarch64-linux bots and bisecting
the commits on the build [1] that introduced the regression it points to this
one. I don't understand exactly what is triggering the issue, but it only
happen on the stage2 build with sta
This revision was automatically updated to reflect the committed changes.
Closed by commit rGed8dadb37c7e: [Sema] Improve diagnostic about addr spaces
for overload candidates (authored by Anastasia).
Herald added a project: clang.
Changed prior to commit:
https://reviews.llvm.org/D7?vs=2335
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, that looks much better.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D7/new/
https://reviews.llvm.org/D7
___
cfe-com
Anastasia updated this revision to Diff 233579.
Anastasia marked an inline comment as done.
Anastasia added a comment.
- Moved "address space" printing into diagnostic engine
- Moved `LangAS::Default` into switch/case statement.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D7/new/
h
rjmccall added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3838
+"'this' object is in address space %3, but method expects object in "
+"address space %4">;
def note_ovl_candidate_bad_gc : Note<
I think you need to move
Anastasia updated this revision to Diff 233424.
Anastasia added a comment.
- Allow sending address spaces into diagnostics
- Change wording of diagnostics for address spaces in overloading
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D7/new/
https://reviews.llvm.org/D7
Files:
rjmccall added a comment.
Hmm. How about:
// For the `this` argument
candidate function not viable: 'this' object is in '__private' address space,
but method expects object in '__global' address space
// For pointer arguments
candidate function not viable: cannot pass pointer to '__p
Anastasia created this revision.
Anastasia added a reviewer: rjmccall.
Herald added a subscriber: ebevhan.
As discussed in https://reviews.llvm.org/D69938#inline-629726 this commit
improves the diagnostic of addr spaces. The approach is currently reusing
diagnostic streaming of `Qualifiers`.
Th
